Repository navigation
Make OptableConfig options settable after construction - #64
Open
jrosendahl-opt wants to merge 1 commit into
Open
jrosendahl-opt wants to merge 1 commit into
jrosendahl-opt wants to merge 1 commit into
Conversation
host, path, insecure, apiKey, customUserAgent and cacheTtl were internal vals, so Java callers had to pass every preceding constructor parameter to set one. Make them public vars, like origin and consents and like the iOS SDK. apiKey, customUserAgent and cacheTtl now apply from the next call. host, path and insecure build the base URL and storage keys, so they are read when OptableSDK is created; the KDoc and README say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
host,path,insecure,apiKey,customUserAgentandcacheTtlwereinternal vals, so from Java the only way to set one was the@JvmOverloadsconstructor with every preceding parameter (eleven arguments to changecacheTtl). The iOS SDK exposes all of its config settings asvars.